Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #6069 #6073

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Fix #6069 #6073

merged 1 commit into from
Feb 14, 2024

Conversation

Jules-Bertholet
Copy link
Contributor

@Jules-Bertholet Jules-Bertholet commented Feb 13, 2024 •
edited
Loading

Fixes #6069. @ytmimi

ytmimi
ytmimi reviewed Feb 13, 2024
View reviewed changes
Copy link
Contributor

@ytmimi ytmimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pulling this into a standalone PR independent from #6072. I'd like to see some minor tweaks and then I think we'll be good to go.

src/items.rs Outdated Show resolved Hide resolved
tests/target/issue_6069.rs Show resolved Hide resolved
ytmimi
ytmimi approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@ytmimi ytmimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those changes, and for the fix! Just waiting on CI.

@ytmimi ytmimi added pr-ready-to-merge release-notes Needs an associated changelog entry and removed pr-not-reviewed labels Feb 14, 2024
@ytmimi ytmimi merged commit 5805040 into rust-lang:master Feb 14, 2024
27 checks passed
@Jules-Bertholet Jules-Bertholet deleted the fix-6069 branch February 14, 2024 20:34
@ytmimi ytmimi mentioned this pull request Apr 7, 2024
Merged
@ytmimi ytmimi removed pr-ready-to-merge release-notes Needs an associated changelog entry labels Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ytmimi ytmimi ytmimi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ICE when formatting trait declaration with non-NFC name
3 participants
@Jules-Bertholet @ytmimi @rustbot